Bug 15792

Summary: Double-clicking the 'renew' button on circulation.pl will double-charge account management fee
Product: Koha Reporter: Barton Chittenden <barton>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: bdaeuber, clackman, gmcharlt, kyle.m.hall, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Barton Chittenden 2016-02-10 21:43:37 UTC
PREREQUISITES
1) Create an account type that has an enrollment fee, and create a borrower of that type.
2) Write off any account management fees charged to that borrower by the account creation.

STEPS TO RE-CREATE
1) Change borrower's dateexpiry to make the borrower expired.
2) Paste borrower's card number into 'Check out' bar
3) A warning will appear saying that the borrower's account has expired, including a 'Renew' link.
4) Double-click the link
5) Check the borrower's fines. You will see two account management fees in a row. distinct from the fee that was written off just after the patron was created.
Comment 1 Marc VĂ©ron 2016-10-07 16:47:08 UTC
Confirmed.
Comment 2 Owen Leonard 2018-10-05 17:22:09 UTC
Rather than try to address this in the template I wonder if it would make sense to add a check to the renewal process to abort the process if the patron's expiration date is already set to the date calculated by the renew_account?
Comment 3 Benjamin Daeuber 2022-01-12 19:58:36 UTC
(In reply to Owen Leonard from comment #2)
> Rather than try to address this in the template I wonder if it would make
> sense to add a check to the renewal process to abort the process if the
> patron's expiration date is already set to the date calculated by the
> renew_account?

I agree with this. There's really no reason I can think of the renew to the same day.