| Summary: | C4::Koha::displayServers is no longer in use | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, m.de.rooy, mtompset |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 15779 | ||
| Attachments: |
Bug 15798: Remove C4::Koha::displayServers
[SIGNED-OFF] Bug 15798: Remove C4::Koha::displayServers Bug 15798: Remove C4::Koha::displayServers |
||
|
Description
Jonathan Druart
2016-02-11 13:57:23 UTC
Created attachment 47896 [details] [review] Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. I agree. mtompset@debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 59fc325 Bug 15684: Fix encoding issues with quote upload mtompset@debian:~/kohaclone$ git grep -n displayServers C4/Koha.pm:53: &displayServers C4/Koha.pm:1013:=head2 displayServers C4/Koha.pm:1015: my $servers = displayServers(); C4/Koha.pm:1016: my $servers = displayServers( $position ); C4/Koha.pm:1017: my $servers = displayServers( $position, $type ); C4/Koha.pm:1019:displayServers returns a listref of hashrefs, each containing C4/Koha.pm:1037:sub displayServers { mtompset@debian:~/kohaclone$ git bz apply 15798 Bug 15798 - C4::Koha::displayServers is no longer in use 47896 - Bug 15798: Remove C4::Koha::displayServers Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15798: Remove C4::Koha::displayServers mtompset@debian:~/kohaclone$ git grep -n displayServers mtompset@debian:~/kohaclone$ Created attachment 47900 [details] [review] [SIGNED-OFF] Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. NOTE: See my testing output in comment #2. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 47952 [details] [review] Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master, thanks Jonathan! Should be in the Koha 3.24 release. |