Bug 15824

Summary: 'Done' button is unclear on batch item modification and deletion
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: ToolsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, jonathan.druart, veron
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15824 - 'Done' button is unclear on batch item modification and deletion
[SIGNED-OFF] Bug 15824 - 'Done' button is unclear on batch item modification and deletion
Bug 15824 - 'Done' button is unclear on batch item modification and deletion
Bug 15824 - 'Done' button is unclear on batch item modification and deletion
Button and link in batch item deletion result page
Bug 15824 - 'Done' button is unclear on batch item modification and deletion
Bug 15824 - 'Done' button is unclear on batch item modification and deletion

Description Aleisha Amohia 2016-02-16 02:07:47 UTC
To reproduce, go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1)
Click edit -> Edit items in a batch
Click Save (you don't need to make any changes)
Notice Done link at the bottom of the page is not very noticeable. This is the same with batch item deletion as well.
Comment 1 Aleisha Amohia 2016-02-16 02:16:33 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-02-16 02:17:59 UTC
Sponsored-by: Catalyst IT
Comment 3 Owen Leonard 2016-02-16 17:20:41 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-02-17 15:52:28 UTC
After modifying items (from the catalogue/detail.pl), I get a screen with:

5 item(s) modified (with 5 fields modified).
Return to where you were 
[TABLE]
Done button

If I click on the done button, I am not redirected to the detail page but the still on the batch tool with the same screen "item(s) modified (with fields modified)."

The submit button you have added is in a form, the window.location.href does not work and the form is submitted.
Comment 5 Aleisha Amohia 2016-03-03 01:29:40 UTC Comment hidden (obsolete)
Comment 6 Mark Tompsett 2016-03-23 18:07:16 UTC
Comment on attachment 48565 [details] [review]
Bug 15824 - 'Done' button is unclear on batch item modification and deletion

Review of attachment 48565 [details] [review]:
-----------------------------------------------------------------

Comments base on eyeballing.

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
@@ +161,5 @@
> +            [% ELSIF src %]
> +                <a href="[% src %]">Return to where you were</a>
> +            [% ELSE %]
> +                <a href="/cgi-bin/koha/tools/batchMod.pl?del=1">Return to batch item deletion</a>
> +            [% END %]

Why not style this identical to the existing block below?

@@ +192,4 @@
>  
>      <p>
>          [% IF src == 'CATALOGUING' # from catalogue/detail.pl > Delete items in a batch%]
> +           <a class="btn" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to the record", as above?

@@ +196,2 @@
>          [% ELSIF src %]
> +           <a class="btn" href="[% src %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to where you were", as above?

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
@@ +66,5 @@
> +                  [% ELSIF src %]
> +                      <a href="[% src %]">Return to where you were</a>
> +                  [% ELSE %]
> +                      <a href="/cgi-bin/koha/tools/batchMod.pl">Return to batch item modification</a>
> +                  [% END %]

Why not style this block as was done below?

@@ +245,4 @@
>  [% ELSE %] <!-- // show -->
>  <fieldset class="action">
>  [% IF src == 'CATALOGUING' # from catalogue/detail.pl > Edit items in a batch%]
> +   <a class="btn" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to where you were", as above?

@@ +249,2 @@
>  [% ELSIF src %]
> +   <a class="btn" href="[% src %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to where you were", as above?
Comment 7 Aleisha Amohia 2016-03-23 22:10:20 UTC Comment hidden (obsolete)
Comment 8 Marc Véron 2016-03-24 09:20:32 UTC
Created attachment 49525 [details]
Button and link in batch item deletion result page

Buttons for batch item modification look fine.

Regarding batch item deletion:

The "Return" button appears in addition to the "Return" links on all Batch item deletion results.
I think it would be better to replace the link with the button at the position where the link is (inside the blueish result message box).
Comment 9 Aleisha Amohia 2016-03-29 00:51:28 UTC
(In reply to Marc Véron from comment #8)
> Created attachment 49525 [details]
> Button and link in batch item deletion result page
> 
> Buttons for batch item modification look fine.
> 
> Regarding batch item deletion:
> 
> The "Return" button appears in addition to the "Return" links on all Batch
> item deletion results.
> I think it would be better to replace the link with the button at the
> position where the link is (inside the blueish result message box).

Hi Marc,

Can I ask why you think this would look better? The behaviour is exactly the same for batch item modification.
Comment 10 Marc Véron 2016-03-29 08:51:50 UTC
(In reply to Aleisha Amohia from comment #9)
> (In reply to Marc Véron from comment #8)
> > Created attachment 49525 [details]
> > Button and link in batch item deletion result page
> > 
> > Buttons for batch item modification look fine.
> > 
> > Regarding batch item deletion:
> > 
> > The "Return" button appears in addition to the "Return" links on all Batch
> > item deletion results.
> > I think it would be better to replace the link with the button at the
> > position where the link is (inside the blueish result message box).
> 
> Hi Marc,
> 
> Can I ask why you think this would look better? The behaviour is exactly the
> same for batch item modification.

Not a big deal. It was because the "Return to..." appears twice, one time as a link inside the message box and one time as button underneath.

But you are right, it looks the same as with batch item modification. 

Signing off.
Comment 11 Marc Véron 2016-03-29 08:53:08 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2016-03-30 14:55:35 UTC
Comment on attachment 49621 [details] [review]
Bug 15824 - 'Done' button is unclear on batch item modification and deletion

Review of attachment 49621 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
@@ +251,2 @@
>  [% ELSE %]
> +   <a class="btn" href="/cgi-bin/koha/tools/batchMod.pl"><i class="fa fa-check-square-o"></i> Return to batch item modification</a>

Do you all agree on this fa-check-square icon?
Comment 13 Marc Véron 2016-03-30 15:08:39 UTC
(In reply to Jonathan Druart from comment #12)
> Comment on attachment 49621 [details] [review] [review]
> Bug 15824 - 'Done' button is unclear on batch item modification and deletion
> 
> Review of attachment 49621 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
> @@ +251,2 @@
> >  [% ELSE %]
> > +   <a class="btn" href="/cgi-bin/koha/tools/batchMod.pl"><i class="fa fa-check-square-o"></i> Return to batch item modification</a>
> 
> Do you all agree on this fa-check-square icon?

OK for me.
Comment 14 Jonathan Druart 2016-04-04 11:46:21 UTC
Created attachment 49849 [details] [review]
Bug 15824 - 'Done' button is unclear on batch item modification and deletion

EDIT: Making sure the messages and the buttons show the same text, as per Comment 6.

To test:

MODIFICATION
1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1)
2) Click edit -> Edit items in a batch
3) Click Save (you don't need to make any changes)
4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page.

5) Go to a biblio record page
6) Select one or some or all items in the record
7) Click modify selected items
8) Click Save
9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page.

10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl)
11) Write some barcodes into the barcode list and click Continue
12) Click Save
13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page.

DELETION
14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1)
15) Click edit -> Delete items in a batch
16) Unselect all the items so you don't actually delete them, then click Delete selected items
17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page.

18) Go to a biblio record page
19) Select one or some or all items in the record
20) Click Delete selected items
21) Unselect all the items so you don't actually delete them, then click Delete selected items
22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page.

23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1)
24) Write some barcodes into the barcode list and click Continue
25) Unselect all the items so you don't actually delete them, then click Delete selected items
26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 15 Brendan Gallagher 2016-04-07 05:38:24 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 16 Jonathan Druart 2016-07-15 13:55:11 UTC
Aleisha, when deleting items using the batch item deletion tools, I now get 2 "Return to batch item deletion": 1 button and 1 link.
Comment 17 Aleisha Amohia 2016-07-19 03:29:53 UTC
(In reply to Jonathan Druart from comment #16)
> Aleisha, when deleting items using the batch item deletion tools, I now get
> 2 "Return to batch item deletion": 1 button and 1 link.

Hi Jonathan, you should have 2 as you've described - the link in the purple message box at the top, and the button at the bottom of all of the deleted items (handy if deleting many items and would have to scroll all the way back to the top)
Comment 18 Owen Leonard 2016-07-20 15:07:23 UTC
(In reply to Jonathan Druart from comment #16)
> Aleisha, when deleting items using the batch item deletion tools, I now get
> 2 "Return to batch item deletion": 1 button and 1 link.

Having both the link and the button makes sense with batch item modifications when the list of modified items is displayed.

On the batch item deletion confirmation screen I think we should move the button into the [% IF ( not_deleted_loop ) %] block so that it is only shown if the page is listing items which could not be deleted.
Comment 19 Aleisha Amohia 2016-07-20 22:05:34 UTC
(In reply to Owen Leonard from comment #18)
> (In reply to Jonathan Druart from comment #16)
> > Aleisha, when deleting items using the batch item deletion tools, I now get
> > 2 "Return to batch item deletion": 1 button and 1 link.
> 
> Having both the link and the button makes sense with batch item
> modifications when the list of modified items is displayed.
> 
> On the batch item deletion confirmation screen I think we should move the
> button into the [% IF ( not_deleted_loop ) %] block so that it is only shown
> if the page is listing items which could not be deleted.

See Bug 16948 for a fix for this