Bug 15832

Summary: Pending reserves: duplicates branches in datatable filter
Product: Koha Reporter: Alex Arnaud <alex.arnaud>
Component: CirculationAssignee: Alex Arnaud <alex.arnaud>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: brendan, david.roberts, f.demians, fiona.borthwick, gmcharlt, jonathan.druart, julian.maurice, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 15832 - Fix items split-up in pendingreserves.tt
Bug 15832 - Fix items split-up in pendingreserves.tt
Bug 15832 - Fix items split-up in pendingreserves.tt
Bug 15832 - Fix filter and items split-up in pendingreserves.tt
[SIGNED-OFF] Bug 15832 - Fix filter and items split-up in pendingreserves.tt
Bug 15832 - Fix filter and items split-up in pendingreserves.tt
Bug 15832: Remove empty string from the filters

Description Alex Arnaud 2016-02-16 15:30:03 UTC
In the datatable of pending reserves, if a title has several branches, this cause duplicates in the filter select.
Comment 1 Alex Arnaud 2016-02-16 15:34:44 UTC Comment hidden (obsolete)
Comment 2 Alex Arnaud 2016-03-01 11:31:21 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2016-03-04 15:48:42 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-03-11 09:14:36 UTC
The patch removes the duplicates but does not fix the filter.
If you have:

----
L1
L2
----
L1
----
L2
L3

and you select the L2 filter, you will only see the 3rd line
if you select L3, all lines will be hidden.
Comment 5 David Roberts 2016-03-11 14:12:50 UTC
Tested this on a customer's system at 3.22. The duplicate libraries still display.
Comment 6 Alex Arnaud 2016-03-30 12:41:52 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2016-04-04 18:12:00 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-04-05 06:41:38 UTC
Created attachment 49892 [details] [review]
Bug 15832 - Fix filter and items split-up in pendingreserves.tt

Test plan:

- Go to circ/pendingreserves.pl (Ensure that there are biblios with many
  items on different branches),
- Check the libraries filter at the bottom of datatable. There should be
  duplicates.
- Apply this patch and return to circ/pendingreserves.pl,
- check that libraries filter should not contain duplicate,
- check that the filter works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2016-04-05 06:41:42 UTC
Created attachment 49893 [details] [review]
Bug 15832: Remove empty string from the filters

On each cell, the split will generate a new empty entry.
This patch removes that entry.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Brendan Gallagher 2016-04-20 20:43:49 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks !
Comment 11 Julian Maurice 2016-04-21 07:57:32 UTC
Patches pushed to 3.22.x, will be in 3.22.6
Comment 12 Frédéric Demians 2016-04-27 15:32:32 UTC
Pushed to 3.22.x, will be in 3.20.11.