Summary: | Bad variable value in renewal template confirmation dialog | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, gmcharlt, julian.maurice, kyle.m.hall, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/renew.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object
[SIGNED-OFF] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object |
Description
Owen Leonard
2016-02-16 15:46:36 UTC
Created attachment 48143 [details] [review] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Created attachment 48146 [details] [review] [SIGNED-OFF] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 48227 [details] [review] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Link repaired. At first glance, I am wondering if biblioitemnumber is of actual use here; is it only passed back and forth between script and template? Pushed to Master - should be in the May 2016 release - thanks! Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |