Description
Alex Arnaud
2016-02-17 11:08:01 UTC
Created attachment 48163 [details] [review] Bug 15838 - Subscription duplicating: Reset fields from SubscriptionDuplicateDroppedInput syspef by getting them using name instead of id Verified bug with startdate and enddate on second page. Created attachment 49526 [details] [review] Bug 15838 - Subscription duplicating: Reset fields from SubscriptionDuplicateDroppedInput syspef by getting them using name instead of id How I tested: Verified bug with start and end date (were not cleared without patch). After applying the patch all fields defined in SubscriptionDuplicateDroppedInput were cleared as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49565 [details] [review] Bug 15838 - Subscription duplicating: Reset fields from SubscriptionDuplicateDroppedInput syspef by getting them using name instead of id How I tested: Verified bug with start and end date (were not cleared without patch). After applying the patch all fields defined in SubscriptionDuplicateDroppedInput were cleared as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> This patch is not perfect, but the feature is so ugly (I have written it...) and so poorly documented that I am almost sure nobody uses it. The id/name does not match the db column in all cases, I don't understand how a librarian could guess them! Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 Pushed to 3.20.x, will be in 3.20.11. |