Bug 15841

Summary: Final truth value in C4:Circulation has become displaced
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: CirculationAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: brendan, gmcharlt, jonathan.druart, julian.maurice, kyle.m.hall, m.de.rooy, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 11201    
Bug Blocks:    
Attachments: Proposed patch
Bug 15841 Circulation module's true value misplaced
Bug 15841 Circulation module's true value misplaced

Description Colin Campbell 2016-02-17 12:47:24 UTC
Last thing in a module should be a true value, looks as though a subroutine has been added after the one in circulation. Lets put it back where it should be
Comment 1 Colin Campbell 2016-02-17 12:52:28 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-22 10:04:28 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-22 10:58:00 UTC
Created attachment 48272 [details] [review]
Bug 15841 Circulation module's true value misplaced

1; was not at the end of the module as it should be
to ensure compilation returns true
return it to last line of code where it should be

This patch fixes an ovious mistake.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Marcel de Rooy 2016-02-22 12:55:45 UTC
Good catch.

> This patch fixes an ovious mistake.
:)
Comment 5 Brendan Gallagher 2016-02-24 03:05:35 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks !
Comment 6 Julian Maurice 2016-02-26 15:44:19 UTC
Patch pushed to 3.22.x, will be in 3.22.4