Summary: | Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Tools | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | brendan, julian.maurice, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 9303 | ||
Bug Blocks: | 15840 | ||
Attachments: |
Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts
[SIGNED-OFF] Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts |
Description
Jonathan Druart
2016-02-17 14:20:21 UTC
Created attachment 48190 [details] [review] Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur (In reply to Kyle M Hall from comment #1) > The same issue seems to occur for sms_provider_id. Confirmed. Created attachment 48263 [details] [review] [SIGNED-OFF] Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur NOTE: While this patch does work, should it be solved only at this level? The issue that there is the lack of those two fields on the tools screen still exists. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #3) > NOTE: While this patch does work, should it be solved only > at this level? The issue that there is the lack of those two > fields on the tools screen still exists. Could you detail? I don't understand what you suggest. (In reply to Jonathan Druart from comment #4) > Could you detail? > I don't understand what you suggest. "The issue that there is the lack of those two fields on the tools screen still exists." If they did exist, then I think the issue would be corrected in part (not in whole) from the proper use of the UI. Whereas, a crafted direct call would still be buggy. This corrects both, but it still leaves the UI incomplete (missing the SMS and guarantor fields). No warning messages tends to leave the problem unfixed. I wonder if those 2 are interesting for patron load, but maybe in the context of migrations? Adding to the tool page could go on a separate bug report. (In reply to Katrin Fischer from comment #6) > I wonder if those 2 are interesting for patron load, but maybe in the > context of migrations? Adding to the tool page could go on a separate bug > report. That works for me. Created attachment 48434 [details] [review] Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur NOTE: While this patch does work, should it be solved only at this level? The issue that there is the lack of those two fields on the tools screen still exists. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Does not concern stable versions, status changed to RESOLVED |