| Summary: | Correct JSHint errors in staff-global.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15844 - Correct JSHint errors in staff-global.js
Bug 15844 - Correct JSHint errors in staff-global.js Bug 15844 - Correct JSHint errors in staff-global.js |
||
|
Description
Owen Leonard
2016-02-17 14:53:22 UTC
Created attachment 48188 [details] [review] Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Created attachment 48192 [details] [review] Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No errors with JSHint CLI (6 errors fixed) Created attachment 48210 [details] [review] Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No errors with JSHint CLI (6 errors fixed) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.4 |