| Summary: | Renewal date in circulation.pl is not always correct and not even used | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Circulation | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | brendan, gmcharlt, julian.maurice, kyle.m.hall, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15845: Renewal date in circulation.pl is not always correct and not even used
Bug 15845: Renewal date in circulation.pl is not always correct and not even used Bug 15845: Renewal date in circulation.pl is not always correct and not even used Bug 15845: Do not import Add_Delta_YM from circulation.pl |
||
|
Description
Marcel de Rooy
2016-02-17 15:32:59 UTC
Created attachment 48189 [details] [review] Bug 15845: Renewal date in circulation.pl is not always correct and not even used If you have a patron category with a hard renewal date, the enrolllment period will be zero. You cannot calculate the renewal date as is done in the script currently. Even more, the renewaldate template var is not even used. Test plan: [1] Verify that checkin/checkout works as expected. [2] Git grep on renewaldate [3] Check the code in circulation.pl for "$renew" Created attachment 48266 [details] [review] Bug 15845: Renewal date in circulation.pl is not always correct and not even used If you have a patron category with a hard renewal date, the enrolllment period will be zero. You cannot calculate the renewal date as is done in the script currently. Even more, the renewaldate template var is not even used. Test plan: [1] Verify that checkin/checkout works as expected. [2] Git grep on renewaldate [3] Check the code in circulation.pl for "$renew" Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 48270 [details] [review] Bug 15845: Renewal date in circulation.pl is not always correct and not even used If you have a patron category with a hard renewal date, the enrolllment period will be zero. You cannot calculate the renewal date as is done in the script currently. Even more, the renewaldate template var is not even used. Test plan: [1] Verify that checkin/checkout works as expected. [2] Git grep on renewaldate [3] Check the code in circulation.pl for "$renew" Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 48271 [details] [review] Bug 15845: Do not import Add_Delta_YM from circulation.pl This subroutine is no longer used in this script. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. thanks! Patch pushed to 3.22.x, will be in 3.22.4 |