Summary: | Correct JSHint errors in basket.js in the staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, julian.maurice, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 15847 - Correct JSHint errors in basket.js in the staff client
[SIGNED-OFF]Bug 15847: Correct JSHint errors in basket.js in the staff client Bug 15847: Correct JSHint errors in basket.js in the staff client |
Description
Owen Leonard
2016-02-17 17:15:12 UTC
Created attachment 48195 [details] [review] Bug 15847 - Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Created attachment 48197 [details] [review] [SIGNED-OFF]Bug 15847: Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No warnigns raised with jshint tool Created attachment 48206 [details] [review] Bug 15847: Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No warnigns raised with jshint tool Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> pushed to master - should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.4 |