|
Description
Nick Clemens (kidclamp)
2016-02-22 13:49:23 UTC
db_max for this format also has a similar problem to 'annual' in bug 15877 Created attachment 51477 [details] [review] Bug 15878 - Updated unit tests for hbyymmincr barcodes Test plan in second patch Created attachment 51478 [details] [review] Bug 15878 - Updated unit tests for hbyymmincr barcodes Test plan in second patch Created attachment 51479 [details] [review] Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max and should warn when no branchcode present Test plan: 1 - prove t/db_dependent/Barcodes.t 2 - All should pass 3 - Apply first patch (unit tests update) 4 - Tests should fail on values and warnings 5 - Apply second patch 6 - All tests should now pass Created attachment 51624 [details] [review] [SIGNED-OFF] Bug 15878 - Updated unit tests for hbyymmincr barcodes Test plan in second patch Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 51625 [details] [review] [SIGNED-OFF] Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max and should warn when no branchcode present Test plan: 1 - prove t/db_dependent/Barcodes.t 2 - All should pass 3 - Apply first patch (unit tests update) 4 - Tests should fail on values and warnings 5 - Apply second patch 6 - All tests should now pass Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described Removed tab on line 47 of C4/Barcodes/hbyymmincr.pm No more qa errors Comment on attachment 51624 [details] [review] [SIGNED-OFF] Bug 15878 - Updated unit tests for hbyymmincr barcodes Review of attachment 51624 [details] [review]: ----------------------------------------------------------------- ::: t/db_dependent/Barcodes.t @@ +84,4 @@ > }; > > > +$schema->storage->txn_begin; There is an issue (existed before this patch), the transaction should begin in the subtests. @@ +96,5 @@ > + source => 'Branch', > + branchcode => 'LETTERS', > + }); > + > + my $branchcode_1 = "LETT"; LETT vs LETTERS? $barcode_branch is never used later. @@ +97,5 @@ > + branchcode => 'LETTERS', > + }); > + > + my $branchcode_1 = "LETT"; > + print "$branchcode_1\n"; Unused debug statement. Created attachment 51688 [details] [review] Bug 15878 - QA Followup * Remove debug statment * Move transcation start * Remove unused testbuilder object Created attachment 51690 [details] [review] Bug 15878 - Updated unit tests for hbyymmincr barcodes Test plan in second patch Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 51691 [details] [review] Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max and should warn when no branchcode present Test plan: 1 - prove t/db_dependent/Barcodes.t 2 - All should pass 3 - Apply first patch (unit tests update) 4 - Tests should fail on values and warnings 5 - Apply second patch 6 - All tests should now pass Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described Removed tab on line 47 of C4/Barcodes/hbyymmincr.pm No more qa errors Created attachment 51692 [details] [review] Bug 15878 - QA Followup * Remove debug statment * Move transcation start * Remove unused testbuilder object Rebased on top of 16561 Created attachment 51694 [details] [review] Bug 15878 - Updated unit tests for hbyymmincr barcodes Test plan in second patch Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 15878 - QA Followup * Remove debug statment * Move transcation start * Remove unused testbuilder object Rebased on top of 16561 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 51695 [details] [review] Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max and should warn when no branchcode present Test plan: 1 - prove t/db_dependent/Barcodes.t 2 - All should pass 3 - Apply first patch (unit tests update) 4 - Tests should fail on values and warnings 5 - Apply second patch 6 - All tests should now pass Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described Removed tab on line 47 of C4/Barcodes/hbyymmincr.pm No more qa errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I have squashed 1st & 3rd for the readability. Thanks for the quick patch Nick! Pushed to master for 16.05, thanks Nick! Patches pushed to 3.22.x, will be in 3.22.7 |