Summary: | Serials new frequency link should be a toolbar button | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, julian.maurice, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/serials/subscription-frequencies.pl | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 15880 - Serials new frequency link should be a toolbar button
Bug 15880 - Serials new frequency link should be a toolbar button Bug 15880 - Serials new frequency link should be a toolbar button |
Description
Owen Leonard
2016-02-22 16:57:41 UTC
Created attachment 48304 [details] [review] Bug 15880 - Serials new frequency link should be a toolbar button This patch converts the "new frequency" link to a Bootstrap-style toolbar button in order to maintain consistency. Also included in this patch are some other minor markup corrections: - A colon and space after labels - A 'Cancel' link instead of a button. - "Required" classes for a required field. To test, apply the patch and go to Serials -> Manage frequencies. - Test the "New frequency" button - Confirm that the changes to the entry form look correct. Created attachment 48315 [details] [review] Bug 15880 - Serials new frequency link should be a toolbar button This patch converts the "new frequency" link to a Bootstrap-style toolbar button in order to maintain consistency. Also included in this patch are some other minor markup corrections: - A colon and space after labels - A 'Cancel' link instead of a button. - "Required" classes for a required field. To test, apply the patch and go to Serials -> Manage frequencies. - Test the "New frequency" button - Confirm that the changes to the entry form look correct. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 48463 [details] [review] Bug 15880 - Serials new frequency link should be a toolbar button This patch converts the "new frequency" link to a Bootstrap-style toolbar button in order to maintain consistency. Also included in this patch are some other minor markup corrections: - A colon and space after labels - A 'Cancel' link instead of a button. - "Required" classes for a required field. To test, apply the patch and go to Serials -> Manage frequencies. - Test the "New frequency" button - Confirm that the changes to the entry form look correct. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |