Summary: | Serials new numbering pattern link should be a toolbar button | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, julian.maurice, testopia, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/serials/subscription-numberpatterns.pl | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15881 - Serials new numbering pattern link should be a toolbar button
Bug 15881 - Serials new numbering pattern link should be a toolbar button Bug 15881 - Serials new numbering pattern link should be a toolbar button |
Description
Owen Leonard
2016-02-22 16:58:58 UTC
Created attachment 48305 [details] [review] Bug 15881 - Serials new numbering pattern link should be a toolbar button This patch converts the "new numbering pattern" link to a Bootstrap-styled toolbar button for consistency with other pages in Koha. This patch also includes minor markup corrections: - Standardizing on the phrase "Numbering patterns" by eliminating the occasional use of "number patterns." - Removing mistaking closing slash on <select> - Using standard "Cancel" link instead of a button. - Adding a colon and space after labels. - Fixing of "no existing patterns" message. To test, apply the patch and go to Serials -> Numbering patterns - Confirm that the "New numbering pattern" button looks correct and works correctly. - Confirm that the entry form looks correct and that the cancel link works as expected. Created attachment 48314 [details] [review] Bug 15881 - Serials new numbering pattern link should be a toolbar button This patch converts the "new numbering pattern" link to a Bootstrap-styled toolbar button for consistency with other pages in Koha. This patch also includes minor markup corrections: - Standardizing on the phrase "Numbering patterns" by eliminating the occasional use of "number patterns." - Removing mistaking closing slash on <select> - Using standard "Cancel" link instead of a button. - Adding a colon and space after labels. - Fixing of "no existing patterns" message. To test, apply the patch and go to Serials -> Numbering patterns - Confirm that the "New numbering pattern" button looks correct and works correctly. - Confirm that the entry form looks correct and that the cancel link works as expected. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 48462 [details] [review] Bug 15881 - Serials new numbering pattern link should be a toolbar button This patch converts the "new numbering pattern" link to a Bootstrap-styled toolbar button for consistency with other pages in Koha. This patch also includes minor markup corrections: - Standardizing on the phrase "Numbering patterns" by eliminating the occasional use of "number patterns." - Removing mistaking closing slash on <select> - Using standard "Cancel" link instead of a button. - Adding a colon and space after labels. - Fixing of "no existing patterns" message. To test, apply the patch and go to Serials -> Numbering patterns - Confirm that the "New numbering pattern" button looks correct and works correctly. - Confirm that the entry form looks correct and that the cancel link works as expected. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |