Bug 15882

Summary: refactor C4::Log::GetLogs to accept DateTime
Product: Koha Reporter: Olli-Antti Kivilahti <olli-antti.kivilahti>
Component: Architecture, internals, and plumbingAssignee: Olli-Antti Kivilahti <olli-antti.kivilahti>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 15882 - refactor C4::Log::GetLogs to accept DateTime

Description Olli-Antti Kivilahti 2016-02-23 09:25:00 UTC
C4::Log::GetLogs accepts dates in the user interface format, which is bad for an internal module.

Refactored to accept DateTimes so it can be used internally more easily.
Comment 1 Olli-Antti Kivilahti 2016-02-23 09:49:58 UTC
Created attachment 48309 [details] [review]
Bug 15882 - refactor C4::Log::GetLogs to accept DateTime

C4::Log::GetLogs accepts dates in some strange format.
It should accept DateTime as that is a de-facto standard.

Refactored to accept DateTimes so it can be used internally more easily.
Also killed a undefined warning bug.
Comment 2 Olli-Antti Kivilahti 2016-02-23 09:50:41 UTC
Missing tests.
Comment 3 Galen Charlton 2016-02-29 18:09:13 UTC
Note that the patch will no longer apply given the work done for bug 14870.
Comment 4 Katrin Fischer 2016-02-29 22:55:03 UTC
C4::Dates is dead and gone...
Comment 5 Katrin Fischer 2023-08-28 21:32:34 UTC
(In reply to Katrin Fischer from comment #4)
> C4::Dates is dead and gone...

As is C4:Logs. Closing INVALID.