|
Description
Owen Leonard
2016-02-23 14:05:59 UTC
Created attachment 48311 [details] [review] Bug 15884 - Vendor contract deletion warning is incorrectly styled When deleting a contract in Acquisitions -> Vendor -> Contracts, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Acquisitions -> [ a vendor] -> Contracts - Try deleting a contract. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Created attachment 48316 [details] [review] Bug 15884 - Vendor contract deletion warning is incorrectly styled When deleting a contract in Acquisitions -> Vendor -> Contracts, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Acquisitions -> [ a vendor] -> Contracts - Try deleting a contract. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 48464 [details] [review] Bug 15884 - Vendor contract deletion warning is incorrectly styled When deleting a contract in Acquisitions -> Vendor -> Contracts, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Acquisitions -> [ a vendor] -> Contracts - Try deleting a contract. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Created attachment 48745 [details] [review] [3.22.x] Bug 15884 - Vendor contract deletion warning is incorrectly styled Patch for 3.22.x Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |