|
Description
Kyle M Hall (khall)
2016-02-24 14:24:02 UTC
Created attachment 48333 [details] [review] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Created attachment 52140 [details] [review] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Tried to test on top of Bug 15896 Can not apply: fatal: sha1 information is lacking or useless (C4/Accounts.pm). Ping Kyle, could you rebase please? Created attachment 58084 [details] [review] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Created attachment 58092 [details] [review] [SIGNED-OFF] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 58094 [details] [review] Bug 15897 - Folowup Revert "Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect" This reverts commit b6d5748c001febc5acd67938d12ba25844d11fbc. As this bug report no more uses the accounline_id parameter to identify account lines to pay in Koha::Account->pay, it should revert this, to use the new notation everywhere. Kyle, could confirm I am right? Thanks accountlines_id has been removed from the param list, but it's still used in tests. We also need tests to highlight this change. Created attachment 58698 [details] [review] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 58699 [details] [review] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 58700 [details] [review] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 58701 [details] [review] Bug 15897 - Folowup Revert "Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect" This reverts commit b6d5748c001febc5acd67938d12ba25844d11fbc. As this bug report no more uses the accounline_id parameter to identify account lines to pay in Koha::Account->pay, it should revert this, to use the new notation everywhere. Created attachment 58702 [details] [review] Bug 15897 [QA Followup] - Update unit tests Created attachment 58724 [details] [review] Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 58725 [details] [review] Bug 15897 - Folowup Revert "Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect" This reverts commit b6d5748c001febc5acd67938d12ba25844d11fbc. As this bug report no more uses the accounline_id parameter to identify account lines to pay in Koha::Account->pay, it should revert this, to use the new notation everywhere. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 58726 [details] [review] Bug 15897 [QA Followup] - Update unit tests Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 58727 [details] [review] Bug 15897: Update ->pay POD Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master for 17.05! This won't get ported back to 16.11.x as it is an enhancement. |