Bug 15898

Summary: Use Koha::Account::pay internally for makepartialpayment
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart+koha, josef.moravec, katrin.fischer, m.de.rooy
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906
Change sponsored?: --- Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15897    
Bug Blocks: 15909    
Attachments: Bug 15898 - Use Koha::Account::pay internally for makepartialpayment
Bug 15898 - Use Koha::Account::pay internally for makepartialpayment
Bug 15898 - Use Koha::Account::pay internally for makepartialpayment
[SIGNED-OFF] Bug 15898 - Use Koha::Account::pay internally for makepartialpayment
Bug 15898 - Use Koha::Account::pay internally for makepartialpayment

Description Kyle M Hall 2016-02-24 14:26:40 UTC

    
Comment 1 Kyle M Hall 2016-02-24 14:29:39 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2016-06-07 15:11:08 UTC
Created attachment 52141 [details] [review]
Bug 15898 - Use Koha::Account::pay internally for makepartialpayment

This is the fourth patch in a series to unify all payment functions into
a single mathod

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay" button,
   but make the payment for less then the full amount
Comment 3 Marcel de Rooy 2016-11-04 10:26:35 UTC
A follow-up on patch 15906 deals too with makepartialpayment and may now interfere with this one. Should be simple to resolve.
Comment 4 Josef Moravec 2016-12-10 09:56:27 UTC
Created attachment 58093 [details] [review]
Bug 15898 - Use Koha::Account::pay internally for makepartialpayment

This is the fourth patch in a series to unify all payment functions into
a single mathod

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay" button,
   but make the payment for less then the full amount
Comment 5 Josef Moravec 2016-12-10 09:57:06 UTC
Just a rebase, now start testing
Comment 6 Josef Moravec 2016-12-10 10:43:59 UTC
Created attachment 58095 [details] [review]
[SIGNED-OFF] Bug 15898 - Use Koha::Account::pay internally for makepartialpayment

This is the fourth patch in a series to unify all payment functions into
a single mathod

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay" button,
   but make the payment for less then the full amount

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Jonathan Druart 2017-01-10 16:32:28 UTC
Created attachment 58765 [details] [review]
Bug 15898 - Use Koha::Account::pay internally for makepartialpayment

This is the fourth patch in a series to unify all payment functions into
a single mathod

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay" button,
   but make the payment for less then the full amount

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Kyle M Hall 2017-01-11 14:39:56 UTC
Pushed to master for 17.05!
Comment 9 Katrin Fischer 2017-01-15 16:04:57 UTC
This won't get ported back to 16.11.x as it is an enhancement.