| Summary: | Obsolete file datatables-strings.inc can be removed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15920 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 15918 - Obsolete file datatables-strings.inc can be removed
Bug 15918 - Obsolete file datatables-strings.inc can be removed Bug 15918: (followup) Correct comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js Bug 15918 - Obsolete file datatables-strings.inc can be removed Bug 15918: (followup) Correct comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js |
||
|
Description
Owen Leonard
2016-02-25 17:02:56 UTC
Created attachment 48375 [details] [review] Bug 15918 - Obsolete file datatables-strings.inc can be removed The include file datatables-strings.inc is no longer necessary. Its contents are now in datatables.inc. This patch corrects two references in comments to datatables-strings.inc (replacing it with datatables.inc) and removes the obsolete file. To test, apply the patch and load any page with a DataTables-enabled table configured to show pagination buttons, e.g. Saved Reports. Pagination labels like "Next," "Previous," and "Showing X of X..." should be correct. Search the codebase to confirm that no references remain for datatables-strings.inc. There seems to be one more comment containing datatables-strings.inc git grep 'datatables-strings.inc' koha-tmpl/opac-tmpl/bootstrap/js/datatables.js:// MSG_DT_* variables comes from datatables-strings.inc Created attachment 50294 [details] [review] Bug 15918 - Obsolete file datatables-strings.inc can be removed The include file datatables-strings.inc is no longer necessary. Its contents are now in datatables.inc. This patch corrects two references in comments to datatables-strings.inc (replacing it with datatables.inc) and removes the obsolete file. To test, apply the patch and load any page with a DataTables-enabled table configured to show pagination buttons, e.g. Saved Reports. Pagination labels like "Next," "Previous," and "Showing X of X..." should be correct. Search the codebase to confirm that no references remain for datatables-strings.inc. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 50295 [details] [review] Bug 15918: (followup) Correct comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js This followup changes comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js line 3 to MSG_DT_* variables comes from datatables.inc Created attachment 50318 [details] [review] Bug 15918 - Obsolete file datatables-strings.inc can be removed The include file datatables-strings.inc is no longer necessary. Its contents are now in datatables.inc. This patch corrects two references in comments to datatables-strings.inc (replacing it with datatables.inc) and removes the obsolete file. To test, apply the patch and load any page with a DataTables-enabled table configured to show pagination buttons, e.g. Saved Reports. Pagination labels like "Next," "Previous," and "Showing X of X..." should be correct. Search the codebase to confirm that no references remain for datatables-strings.inc. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 50319 [details] [review] Bug 15918: (followup) Correct comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js This followup changes comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js line 3 to MSG_DT_* variables comes from datatables.inc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Owen Leonard from comment #0) > The include file datatables-strings.inc is no longer necessary. Its contents > are now in datatables.inc. The last few references to it can be removed and > the file deleted. Not sure it has ever been used actually. Pushed to master for the May 2016 release. Thanks Owen! |