Summary: | DataTables JavaScript files included twice on many pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, julian.maurice, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15921: Do not include datatables js/css files twice
[SIGNED-OFF] Bug 15921: Do not include datatables js/css files twice Bug 15921: Do not include datatables js/css files twice Bug 15921: Do not include datatables js/css files twice [PASSED QA] Bug 15921: Do not include datatables js/css files twice |
Description
Owen Leonard
2016-02-25 19:29:30 UTC
Is there any reason to include dataTables.buttons.min.js and buttons.colVis.min.js on pages which do not have columns configuration enabled? datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. So yes, now it does not make sense to have them included in both files. Created attachment 48433 [details] [review] Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Created attachment 49082 [details] [review] [SIGNED-OFF] Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> With this patch "columns visibility" on administration/currencies doesn't appear to work anymore. Created attachment 49386 [details] [review] Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Created attachment 49433 [details] [review] Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Tested with patron search and administration/currencies, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49481 [details] [review] [PASSED QA] Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Tested with patron search and administration/currencies, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - should be in the May 2016 release. Thanks! Not needed in stable versions, status changed to RESOLVED |