|
Description
Aleisha Amohia
2016-02-29 00:52:26 UTC
Created attachment 48520 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Created attachment 48534 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Hi, I think the menu is a good idea, but the datatable doesn't work here. If you have more than 20 results, the authority search has its own paging - you won't be able to use the paging from the datatables for your results. Also - this change is not part of the bug description! Created attachment 48568 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed ddatatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 48717 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 48823 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> QA comment: There is a wrong behavior: Click on Actions > Delete > Cancel => The scrollbar goes to the top Created attachment 48909 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Was this change intentional? It's a regression from Bug 15927. + [% UNLESS ( loop.odd ) %] + <tr data-authid="[% resul.authid %]" class="highlight"> + [% ELSE %] + <tr data-authid="[% resul.authid %]"> + [% END %] Created attachment 49062 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Comment on attachment 49062 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Review of attachment 49062 [details] [review]: ----------------------------------------------------------------- I don't think comment #9 was dealt with. ::: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt @@ -73,5 @@ > - <th> </th> > - [% END %] > - </tr> > -[% FOREACH resul IN result %] > - <tr data-authid="[% resul.authid %]"> I think you should have kept this <tr> line. Created attachment 49407 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) Edit: Putting <tr> line back To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Created attachment 49432 [details]
Drop down very wide
The drop down list is very wide, is that intended?
(In reply to Marc Véron from comment #13) > Created attachment 49432 [details] > Drop down very wide > > The drop down list is very wide, is that intended? Not intended, and not really sure why it's happening. It has the same with as on /cgi-bin/koha/acqui/invoices.pl Seems to be related to the class dropdown-menu ( min-width: 160px; ) Signing off. Created attachment 49436 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) Edit: Putting <tr> line back To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Created attachment 49464 [details] [review] Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) Edit: Putting <tr> line back To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |