Summary: | Remove unused JavaScript from authorities MARC subfield structure | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, f.demians, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/admin/auth_subfields_structure.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure
Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure |
Description
Owen Leonard
2016-02-29 18:37:55 UTC
Created attachment 48477 [details] [review] Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." Created attachment 48606 [details] [review] Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No regression, no JS warning. Created attachment 48608 [details] [review] Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No regression, no JS warning. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |