Summary: | Use Font Awesome icons for attach item confirmations | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, jonathan.druart, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/cataloguing/moveitem.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 15785 | ||
Bug Blocks: | |||
Attachments: |
Bug 15959 - Use Font Awesome icons for attach item confirmations
[SIGNED-OFF]Bug 15959: Use Font Awesome icons for attach item confirmations Bug 15959: Use Font Awesome icons for attach item confirmations |
Description
Owen Leonard
2016-03-02 16:35:45 UTC
Created attachment 48551 [details] [review] Bug 15959 - Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. Created attachment 48564 [details] [review] [SIGNED-OFF]Bug 15959: Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Created attachment 48614 [details] [review] Bug 15959: Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> It would be interesting to use CSS3 variables (https://www.w3.org/TR/css-variables/) to define the different colors. Pushed to Master - Should be in the May 2016 release. thanks! |