Summary: | Use Font Awesome icons for classification filing rule deletion error | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, jonathan.druart, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/admin/classsources.pl?op=delete_sort_rule | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 15785 | ||
Bug Blocks: | |||
Attachments: |
Bug 15960 - Use Font Awesome icons for classification filing rule deletion error
[SIGNED-OFF]Bug 15960: Use Font Awesome icons for classification filing rule deletion error Bug 15960: Use Font Awesome icons for classification filing rule deletion error |
Description
Owen Leonard
2016-03-02 16:52:43 UTC
Created attachment 48553 [details] [review] Bug 15960 - Use Font Awesome icons for classification filing rule deletion error When deletion of a classification filing rule is impossible, the dialog saying so should be styled with Font Awesome icons. This patch corrects this omission from the patch for Bug 15785. Also changed: The dialog is now an "alert" style dialog instead of a "message" one. To test, apply the patch and go to Administration -> Classification sources. - Locate a classification filing rule which is in use by a classification source. - Click the "Delete" link for that rule and verify that the resulting dialog is correctly styled. - Click the "OK" button and confirm that you are correctly redirected. Created attachment 48627 [details] [review] [SIGNED-OFF]Bug 15960: Use Font Awesome icons for classification filing rule deletion error When deletion of a classification filing rule is impossible, the dialog saying so should be styled with Font Awesome icons. This patch corrects this omission from the patch for Bug 15785. Also changed: The dialog is now an "alert" style dialog instead of a "message" one. To test, apply the patch and go to Administration -> Classification sources. - Locate a classification filing rule which is in use by a classification source. - Click the "Delete" link for that rule and verify that the resulting dialog is correctly styled. - Click the "OK" button and confirm that you are correctly redirected. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertise Created attachment 48937 [details] [review] Bug 15960: Use Font Awesome icons for classification filing rule deletion error When deletion of a classification filing rule is impossible, the dialog saying so should be styled with Font Awesome icons. This patch corrects this omission from the patch for Bug 15785. Also changed: The dialog is now an "alert" style dialog instead of a "message" one. To test, apply the patch and go to Administration -> Classification sources. - Locate a classification filing rule which is in use by a classification source. - Click the "Delete" link for that rule and verify that the resulting dialog is correctly styled. - Click the "OK" button and confirm that you are correctly redirected. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertise Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |