|
Description
Aleisha Amohia
2016-03-03 02:20:44 UTC
Created attachment 48569 [details] [review] Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT It works. But why this:
+ $('#koha2marc').find("input:submit").hide();
Since you have already this:
- <input type="submit" value="OK" />
If at first place, you hide in JS the submit button, isn't it in order to keep working the form whether JS is disabled. So why suppressing the <input> itself? For me, JS has to be activated in the pro interface, and as so, the JS line should be suppressed.
Created attachment 48709 [details] [review] Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu EDIT: Removing JS line To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT Created attachment 48723 [details] [review] Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu EDIT: Removing JS line To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 48729 [details] [review] Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu EDIT: Removing JS line To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 48730 [details] [review] t rebase# Attachment to Bug 15965 - Koha to MARC mapping - table changes with selection of drop down menu Bug 15965: Select default value ('biblio') if needed It will prevent wrong value to be selected when the back button of the browser is used. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |