Summary: | Use Font Awesome icons in subscription frequency deletion confirmation dialog | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, jonathan.druart, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/serials/subscription-frequencies.pl?op=del&frequencyid=X | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 15785 | ||
Bug Blocks: | |||
Attachments: |
Bug 15980 - Use Font Awesome icons in subscription frequency deletion confirmation dialog
[SIGNED-OFF]Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog |
Description
Owen Leonard
2016-03-04 16:30:32 UTC
Created attachment 48698 [details] [review] Bug 15980 - Use Font Awesome icons in subscription frequency deletion confirmation dialog If you try to delete a subscription frequency which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to <form>s to fix validation errors. - Added "alert" class to confirmation dialog so that it is correctly styled. To test, apply the patch and go to Serials -> Frequencies. - Click "Delete" on a frequency which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct frequency. Created attachment 48750 [details] [review] [SIGNED-OFF]Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog If you try to delete a subscription frequency which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to <form>s to fix validation errors. - Added "alert" class to confirmation dialog so that it is correctly styled. To test, apply the patch and go to Serials -> Frequencies. - Click "Delete" on a frequency which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct frequency. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Created attachment 48943 [details] [review] Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog If you try to delete a subscription frequency which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to <form>s to fix validation errors. - Added "alert" class to confirmation dialog so that it is correctly styled. To test, apply the patch and go to Serials -> Frequencies. - Click "Delete" on a frequency which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct frequency. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |