Bug 15983

Summary: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, hector.hecaxmmx, testopia
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=del&id=X
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15785    
Bug Blocks:    
Attachments: Bug 15983 - Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
[SIGNED-OFF]Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog

Description Owen Leonard 2016-03-04 17:14:02 UTC
If you try to delete a serials numbering pattern which is in use by an existing subscription you are presented with a confirmation dialog. This dialog should use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-04 17:35:31 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-03-07 15:09:01 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 11:34:47 UTC
Created attachment 48944 [details] [review]
Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog

If you try to delete a serial numbering pattern which is in use by an
existing subscription you will be shown a confirmation dialog. This
dialog should use Font Awesome icons.

Other minor changes:

- Added "action" attributes to <form>s to fix validation errors.
- Added "alert" class to confirmation dialogs so that they correctly
  styled.

To test, apply the patch and go to Serials -> Numbering patterns.

- Click "Delete" on a numbering pattern which is in use by a
  subscription.
- Verify that the confirmation dialog is styled correctly.
- Test that the "No, do not delete" button works correctly.
- Test that the "Yes, delete" button deletes the correct numbering
  pattern.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-12 23:29:44 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!