Bug 15987

Created attachment 48724 [details] [review]
Bug 15987: Fix undefined subroutine &main::GetCurrency in acqui-home.pl

Bug 15987 and bug 15049 were competing the push to master status at the
same time. Bug 15987 removed the GetCurrency status and bug 15049
reintrocuced one occurrence of this subroutine.

Test plan:
Confirm that the test plan for 15049 still passes.

Created attachment 48725 [details] [review]
Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay

Bug 15987 and bug 11622 were competing the push to master status at the
same time. Bug 15987 removed the GetCurrency status and bug 11622
reintroduced one occurrence of this subroutine.

Test plan:
Confirm that the test plan for 11622 still passes.

(In reply to Jonathan Druart from comment #2)
> Created attachment 48725 [details] [review] [review]
> Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay
> 
> Bug 15987 and bug 11622 were competing the push to master status at the
> same time. Bug 15987 removed the GetCurrency status and bug 11622
> reintroduced one occurrence of this subroutine.
> 
> Test plan:
> Confirm that the test plan for 11622 still passes.

Jonathan, I added a qa followup to bug 15084 that fixes the same issues. Do you think it would be better to close this bug, or to revert my patch and push this bug through the community process?

Hm, the acq start page seems to be ok now in master, but I failed to test the paypal related page.

It asks for a module that I seem to be missing? I was not able to fix that right away.

[Mon Mar 07 23:16:02.290772 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: Can't locate URL/Encode.pm in @INC (you may need to install the URL::Encode module) (@INC contains: /home/katrin/kohaclone /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl
[Mon Mar 07 23:16:02.290880 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: BEGIN failed--compilation aborted at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl
[Mon Mar 07 23:16:02.291551 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] End of script output before headers: opac-account-pay.pl, referer: http://localhost/cgi-bin/koha/opac-account.pl

(In reply to Kyle M Hall from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > Created attachment 48725 [details] [review] [review] [review]
> > Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay
> > 
> > Bug 15987 and bug 11622 were competing the push to master status at the
> > same time. Bug 15987 removed the GetCurrency status and bug 11622
> > reintroduced one occurrence of this subroutine.
> > 
> > Test plan:
> > Confirm that the test plan for 11622 still passes.
> 
> Jonathan, I added a qa followup to bug 15084 that fixes the same issues. Do
> you think it would be better to close this bug, or to revert my patch and
> push this bug through the community process?

If you tested the paypal stuff, I am fine with your patch (I have not tested it!)

(In reply to Katrin Fischer from comment #4)
> Hm, the acq start page seems to be ok now in master, but I failed to test
> the paypal related page.
> 
> It asks for a module that I seem to be missing? I was not able to fix that
> right away.
> 
> [Mon Mar 07 23:16:02.290772 2016] [cgi:error] [pid 32291] [client
> 127.0.0.1:57089] AH01215: Can't locate URL/Encode.pm in @INC (you may need
> to install the URL::Encode module) (@INC contains: /home/katrin/kohaclone
> /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2
> /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18
> /usr/local/lib/site_perl .) at
> /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer:
> http://localhost/cgi-bin/koha/opac-account.pl
> [Mon Mar 07 23:16:02.290880 2016] [cgi:error] [pid 32291] [client
> 127.0.0.1:57089] AH01215: BEGIN failed--compilation aborted at
> /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer:
> http://localhost/cgi-bin/koha/opac-account.pl
> [Mon Mar 07 23:16:02.291551 2016] [cgi:error] [pid 32291] [client
> 127.0.0.1:57089] End of script output before headers: opac-account-pay.pl,
> referer: http://localhost/cgi-bin/koha/opac-account.pl

URL::Encode does not seem to be packaged in our repo.
See the original bug report for the discussion about this module.