Description
Aleisha Amohia
2016-03-06 22:04:41 UTC
Created attachment 48712 [details] [review] Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Created attachment 48714 [details] [review] Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Created attachment 48820 [details] [review] Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Created attachment 48846 [details] [review] Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons. Created attachment 48900 [details] [review] Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT Created attachment 48901 [details] [review] Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT Created attachment 49052 [details] [review] [SIGNED-OFF] Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 49053 [details] [review] Bug 15989 [Follow-up] Making classification sources actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. Also changed in this patch: A couple of capitalization errors. To test, apply the patch for Bug 16048 and go to Administration -> Classification sources. Confirm that the "Edit" and "Delete" buttons do not stack on top of each other even at narrow browser widths. Created attachment 49232 [details] [review] Bug 15989 [Follow-up] Making classification sources actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. Also changed in this patch: A couple of capitalization errors. To test, apply the patch for Bug 16048 and go to Administration -> Classification sources. Confirm that the "Edit" and "Delete" buttons do not stack on top of each other even at narrow browser widths. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49244 [details] [review] Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 49245 [details] [review] Bug 15989 [Follow-up] Making classification sources actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. Also changed in this patch: A couple of capitalization errors. To test, apply the patch for Bug 16048 and go to Administration -> Classification sources. Confirm that the "Edit" and "Delete" buttons do not stack on top of each other even at narrow browser widths. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - should be in the May 2016 release. Thanks! |