Summary: | Renaming 'Operations' column heading to 'Actions' | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | System Administration | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16036 |
||
Change sponsored?: | Sponsored | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 15992: Moving item search fields actions into a drop-down menu
Bug 15992: Moving item search fields actions into a drop-down menu Bug 15992: Renaming 'Operations' column heading to 'Actions' [SIGNED-OFF] Bug 15992: Renaming 'Operations' column heading to 'Actions' Bug 15992: Renaming 'Operations' column heading to 'Actions' |
Description
Aleisha Amohia
2016-03-06 22:34:58 UTC
Created attachment 48719 [details] [review] Bug 15992: Moving item search fields actions into a drop-down menu To test: 1) Go to Administration -> Item search fields 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Created attachment 48825 [details] [review] Bug 15992: Moving item search fields actions into a drop-down menu To test: 1) Go to Administration -> Item search fields 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> You are loosing the confirmation and highlight made on bug 15887. Created attachment 48905 [details] [review] Bug 15992: Renaming 'Operations' column heading to 'Actions' to be consistent with other Administration tables These actions were already made into buttons so will just make this small string change To test: 1) Go to Admin -> Item search fields 2) Confirm column heading now reads 'Actions' Sponsored-by: Catalyst IT Created attachment 48907 [details] [review] [SIGNED-OFF] Bug 15992: Renaming 'Operations' column heading to 'Actions' to be consistent with other Administration tables These actions were already made into buttons so will just make this small string change To test: 1) Go to Admin -> Item search fields 2) Confirm column heading now reads 'Actions' Sponsored-by: Catalyst IT NOTE: Trivial string change, screen refresh confirms change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Aleisha, seems to be the common way to "named" the actions column: % git grep '<th> </th>' **/*.tt|wc 127 339 13098 % git grep '<th>Actions</th>' **/*.tt|wc 15 33 1485 (In reply to Jonathan Druart from comment #6) > Aleisha, > seems to be the common way to "named" the actions column: > > % git grep '<th> </th>' **/*.tt|wc > 127 339 13098 > % git grep '<th>Actions</th>' **/*.tt|wc > 15 33 1485 I think it tends to be that when the actions have been moved into a drop down menu, the column gets named because each drop down has Actions on it. But when there is no drop down and it is just buttons like this, the column name should be Actions. Created attachment 48989 [details] [review] Bug 15992: Renaming 'Operations' column heading to 'Actions' to be consistent with other Administration tables These actions were already made into buttons so will just make this small string change To test: 1) Go to Admin -> Item search fields 2) Confirm column heading now reads 'Actions' Sponsored-by: Catalyst IT NOTE: Trivial string change, screen refresh confirms change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Aleisha Amohia from comment #7) > (In reply to Jonathan Druart from comment #6) > > Aleisha, > > seems to be the common way to "named" the actions column: > > > > % git grep '<th> </th>' **/*.tt|wc > > 127 339 13098 > > % git grep '<th>Actions</th>' **/*.tt|wc > > 15 33 1485 > > I think it tends to be that when the actions have been moved into a drop > down menu, the column gets named because each drop down has Actions > on it. But when there is no drop down and it is just buttons like this, the > column name should be Actions. Indeed, it makes sense! Thanks for the clarification :) Pushed to Master - Should be in the May 2016 release. Thanks! |