Description
Aleisha Amohia
2016-03-06 22:52:29 UTC
Created attachment 48722 [details] [review] Bug 15995: Moving libraries actions into a drop-down menu To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and buttons behave as expected. Sponsored-by: Catalyst IT Created attachment 48828 [details] [review] Bug 15995: Moving libraries actions into a drop-down menu To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and buttons behave as expected. Sponsored-by: Catalyst IT Comment on attachment 48828 [details] [review] Bug 15995: Moving libraries actions into a drop-down menu Review of attachment 48828 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ +306,5 @@ > <td>[% category.categorycode %]</td> > <td>[% category.codedescription %]</td> > <td> > + <div class="dropdown"> > + <a class="btn btn-mini dropdown-toggle" id="libraryactions[% library.branchcode %]" role="button" data-toggle="dropdown" href="#"> library.branchcode will never be defined on deleting a group of libraries. Note that the deletion of a group of libraries is broken, see bug 16015 for a fix. Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons. Created attachment 48904 [details] [review] Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT Created attachment 49049 [details] [review] [SIGNED-OFF] Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 49050 [details] [review] Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. Created attachment 49067 [details] [review] [SIGNED-OFF] Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> You forgot to add the class to one of the tables, but I have added it Created attachment 49117 [details] [review] Bug 15995: Making libraries actions buttons To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH tables under one column 'Actions' and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 49118 [details] [review] Bug 15995 [Follow-up] Making libraries actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Libraries and Groups. Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> You forgot to add the class to one of the tables, but I have added it Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! |