| Summary: | Use standard message dialog when there are no cities to list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/admin/cities.pl | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14888 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16001 - Use standard message dialog when there are no cities to list
Bug 16001 - Use standard message dialog when there are no cities to list [SIGNED-OFF] Bug 16001 - Use standard message dialog when there are no cities to list Bug 16001 - Use standard message dialog when there are no cities to list |
||
|
Description
Owen Leonard
2016-03-07 17:09:34 UTC
Created attachment 48760 [details] [review] Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. This might be user error, but I applied the patch and see no difference. Nicole Created attachment 51584 [details] [review] Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. Created attachment 51623 [details] [review] [SIGNED-OFF] Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Better view, no errors Created attachment 51667 [details] [review] Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Better view, no errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the November 2016 Release. Thanks! Pushed in 16.05. Will be in 16.05.01. Patch pushed to 3.22.x, will be in 3.22.8 |