Bug 16004

Summary: Replace items.new with items.new_status
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ToolsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: brendan, julian.maurice, kyle, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 11023    
Bug Blocks:    
Attachments: Bug 16004: Replace items.new with items.new_status
Bug 16004: Replace items.new with items.new_status
Bug 16004: Replace items.new with items.new_status
Bug 16004: [QA Follow-up] Tiny change for unit test and help file

Description Jonathan Druart 2016-03-08 09:53:08 UTC
The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead.
It will be renamed with new_status to avoid the ambiguity.
Comment 1 Jonathan Druart 2016-03-08 09:56:35 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2016-03-08 12:41:48 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-03-25 11:11:53 UTC
Created attachment 49585 [details] [review]
Bug 16004: Replace items.new with items.new_status

The items.new column is badly named, the Koha::Item->new accessor will
never returns this value, but the constructor will be called instead.
This patch renames it with new_status to avoid the ambiguity.

Test plan:
0/ Do not apply this patch
1/ Define some rules in the "Automatic item modifications by age" tool
with at least one items.new field used
2/ Apply this patch
3/ Execute the update DB entry
4/ Reload the tool page and confirm that the changes have been taken
into account

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2016-03-25 11:11:56 UTC
Created attachment 49586 [details] [review]
Bug 16004: [QA Follow-up] Tiny change for unit test and help file

Unit test: Added a few lines to add the CPL branch the test depends on.
Help file: Changed a few occurrences for new to new_status

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Brendan Gallagher 2016-03-31 17:13:18 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks  (schema upgraded too)
Comment 6 Julian Maurice 2016-04-07 05:58:51 UTC
Not needed in stable versions, status changed to RESOLVED