Summary: | Classification sources are not deletable | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, gmcharlt, julian.maurice, katrin.fischer, srdjan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16013: Make classification sources deletable
[SIGNED-OFF] Bug 16013: Make classification sources deletable [PASSED QA] Bug 16013: Make classification sources deletable |
Description
Jonathan Druart
2016-03-09 11:28:51 UTC
Created attachment 48847 [details] [review] Bug 16013: Make classification sources deletable Because of a wrong variable scope, the classification sources are not deletable. Test plan: Create a classification sources (admin/classsources.pl) Try to delete it Without this patch, the classification source won't be deleted With this patch, it will work! I'm not having any trouble deleting them without this patch. It certainly occurs under Plack only. Created attachment 49081 [details] [review] [SIGNED-OFF] Bug 16013: Make classification sources deletable Because of a wrong variable scope, the classification sources are not deletable. Test plan: Create a classification sources (admin/classsources.pl) Try to delete it Without this patch, the classification source won't be deleted With this patch, it will work! Signed-off-by: Srdjan <srdjan@catalyst.net.nz> This patch makes sense, however I must say that it worked for me even without it. Created attachment 49338 [details] [review] [PASSED QA] Bug 16013: Make classification sources deletable Because of a wrong variable scope, the classification sources are not deletable. Test plan: Create a classification sources (admin/classsources.pl) Try to delete it Without this patch, the classification source won't be deleted With this patch, it will work! Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tested OK with and without the patch, without Plack. Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 Pushed to 3.20.x, will be in 3.20.10 |