Bug 16019

Summary: Remove unused blue.css
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, jonathan.druart, julian.maurice
Version: Main   
Hardware: All   
OS: All   
URL: /intranet-tmpl/prog/en/css/blue.css
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 16019 - Remove unused blue.css
Bug 16019 - Remove unused blue.css
Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css
Bug 16019 - Remove unused blue.css
[PASSED QA] Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css
[PASSED QA] Bug 16019 - Remove unused blue.css

Description Owen Leonard 2016-03-09 13:48:38 UTC
The last time I asked was in 2011 and the staff client was styled very differently then. The last time the file was updated was 2009.

Is it safe to delete blue.css now? I don't think we should continue to include a file which is not used by Koha's default configuration.
Comment 1 Owen Leonard 2016-03-09 13:54:00 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2016-03-10 06:14:09 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 12:18:08 UTC
I'd suggest to add an update DB entry to check the value of  intranetcolorstylesheet. If it contains "blue.css", we empty it and warn the user that it has been removed.
Comment 4 Jonathan Druart 2016-03-16 11:30:16 UTC
Waiting for an answer.
Comment 5 Owen Leonard 2016-03-18 12:35:47 UTC
(In reply to Jonathan Druart from comment #3)
> I'd suggest to add an update DB entry to check the value of 
> intranetcolorstylesheet. If it contains "blue.css", we empty it and warn the
> user that it has been removed.

I think it's a good idea, but I don't know how to implement it.
Comment 6 Jonathan Druart 2016-03-18 16:34:48 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2016-03-18 16:35:23 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-03-18 16:35:48 UTC
Letting the QA step to another QAer to get another opinion.
Comment 9 Katrin Fischer 2016-03-20 21:45:24 UTC
Hm, updatedatabase.pl?
Comment 10 Katrin Fischer 2016-03-20 21:48:14 UTC
Created attachment 49355 [details] [review]
[PASSED QA] Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2016-03-20 21:48:54 UTC
Created attachment 49356 [details] [review]
[PASSED QA] Bug 16019 - Remove unused blue.css

This patch removes blue.css and one image which was used only by
blue.css, css_header.png.

To test, apply the patch and search Koha files for references to
blue.css and css_header.png. There should be none.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Brendan Gallagher 2016-03-22 01:04:16 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!