|
Description
Owen Leonard
2016-03-09 15:26:12 UTC
Created attachment 48879 [details] [review] Bug 16025 - Use Font Awesome icons on item types localization page The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Created attachment 49190 [details]
Trash icon appears above text
Trash icon appears above the text 'Delete' (instead of at the left of the text), see screenshot.
Created attachment 49221 [details] [review] Bug 16025 [Revised] Use Font Awesome icons on item types localization page The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Revision adds the "actions" class to the table cell with the delete link to prevent a line break between the icon and the text. Created attachment 49224 [details] [review] Bug 16025 [Revised] Use Font Awesome icons on item types localization page The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Revision adds the "actions" class to the table cell with the delete link to prevent a line break between the icon and the text. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49249 [details] [review] Bug 16025 [Revised] Use Font Awesome icons on item types localization page The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Revision adds the "actions" class to the table cell with the delete link to prevent a line break between the icon and the text. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 |