|
Description
Tomás Cohen Arazi (tcohen)
2016-03-09 18:39:43 UTC
Created attachment 48893 [details] [review] Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL Since bug 5010 was pushed, OPACBaseURL already contains the protocol. The sitemap.pl script was written before this was pushed, and thus still concatenates http:// in front of OPACBaseURL. This patch removes this behaviour. To test: - Have OPACBaseURL set to (say) http://myopac.com - Run the sitemap.pl script without specifying the --url param => FAIL: Notice URLs look like http://http://myopac.com/bib... in the sitemap files. - Apply the patch - Run the sitemap.pl script without specifying the --url param => SUCCESS: Notice URLs look correctly like http://myopac.com/bib... - Sign off :-D Regards Created attachment 48894 [details] [review] Bug 16031: (followup) Fix documentation This followup fixes a tiny mistake in the script POD. Created attachment 48897 [details] [review] [SIGNED-OFF] Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL Since bug 5010 was pushed, OPACBaseURL already contains the protocol. The sitemap.pl script was written before this was pushed, and thus still concatenates http:// in front of OPACBaseURL. This patch removes this behaviour. To test: - Have OPACBaseURL set to (say) http://myopac.com - Run the sitemap.pl script without specifying the --url param => FAIL: Notice URLs look like http://http://myopac.com/bib... in the sitemap files. - Apply the patch - Run the sitemap.pl script without specifying the --url param => SUCCESS: Notice URLs look correctly like http://myopac.com/bib... - Sign off :-D Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 48898 [details] [review] [SIGNED-OFF] Bug 16031: (followup) Fix documentation This followup fixes a tiny mistake in the script POD. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 48952 [details] [review] Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL Since bug 5010 was pushed, OPACBaseURL already contains the protocol. The sitemap.pl script was written before this was pushed, and thus still concatenates http:// in front of OPACBaseURL. This patch removes this behaviour. To test: - Have OPACBaseURL set to (say) http://myopac.com - Run the sitemap.pl script without specifying the --url param => FAIL: Notice URLs look like http://http://myopac.com/bib... in the sitemap files. - Apply the patch - Run the sitemap.pl script without specifying the --url param => SUCCESS: Notice URLs look correctly like http://myopac.com/bib... - Sign off :-D Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 48953 [details] [review] Bug 16031: (followup) Fix documentation This followup fixes a tiny mistake in the script POD. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks Patches pushed to 3.22.x, will be in 3.22.5 |