| Summary: | Edit the active currency removes its 'active' flag | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | brendan, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15084 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16053: Add tests
Bug 16053: Do not remove the active flag when editing the active currency [SIGNED-OFF] Bug 16053: Add tests [SIGNED-OFF] Bug 16053: Do not remove the active flag when editing the active currency [PASSED QA] Bug 16053: Add tests [PASSED QA] Bug 16053: Do not remove the active flag when editing the active currency |
||
|
Description
Jonathan Druart
2016-03-11 11:53:10 UTC
Created attachment 49004 [details] [review] Bug 16053: Add tests Created attachment 49005 [details] [review] Bug 16053: Do not remove the active flag when editing the active currency From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. Created attachment 49045 [details] [review] [SIGNED-OFF] Bug 16053: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 49046 [details] [review] [SIGNED-OFF] Bug 16053: Do not remove the active flag when editing the active currency From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 49340 [details] [review] [PASSED QA] Bug 16053: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 49341 [details] [review] [PASSED QA] Bug 16053: Do not remove the active flag when editing the active currency From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release. Thanks! Does not concern stable version, status changed to RESOLVED |