Summary: | Add a button to delete an individual news item | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Tools | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 16372, 19041 | ||
Attachments: |
Bug 16058: Delete individual news item from koha-news.pl
Bug 16058: Delete individual news item from koha-news.pl Bug 16058: Delete individual news item from koha-news.pl Bug 16058: Delete individual news item from koha-news.pl |
Description
Aleisha Amohia
2016-03-13 22:26:19 UTC
Would be good to then style the buttons as font-awesome buttons Created attachment 49617 [details] [review] Bug 16058: Delete individual news item from koha-news.pl This patch adds a confirm message for deleting a news item from the home page in the staff client. It also gives the ability to delete an individual news item from koha-news.pl with a confirm message. The buttons on koha-news.pl are now styled as font awesome buttons. To test: 1) Go to main intranet page. Click 'Delete' for a news item. 2) Confirm that Cancel stops the Delete, and OK deletes the item and takes you to tools/koha-news.pl 3) Confirm that the buttons (Edit and Delete) on koha-news.pl are now styled as font awesome buttons and the buttons don't wrap on a narrow browser. 4) Confirm that the column heading for the buttons is now "Actions". 5) Confirm that clicking Delete triggers a confirm message. Confirm that Cancel stops the Delete, and OK deletes the item and it no longer shows in the News table or anywhere else. Sponsored-by: Catalyst IT Created attachment 49628 [details] [review] Bug 16058: Delete individual news item from koha-news.pl This patch adds a confirm message for deleting a news item from the home page in the staff client. It also gives the ability to delete an individual news item from koha-news.pl with a confirm message. The buttons on koha-news.pl are now styled as font awesome buttons. To test: 1) Go to main intranet page. Click 'Delete' for a news item. 2) Confirm that Cancel stops the Delete, and OK deletes the item and takes you to tools/koha-news.pl 3) Confirm that the buttons (Edit and Delete) on koha-news.pl are now styled as font awesome buttons and the buttons don't wrap on a narrow browser. 4) Confirm that the column heading for the buttons is now "Actions". 5) Confirm that clicking Delete triggers a confirm message. Confirm that Cancel stops the Delete, and OK deletes the item and it no longer shows in the News table or anywhere else. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Any ideas why the buttons are stuck together? (In reply to Jonathan Druart from comment #4) > Any ideas why the buttons are stuck together? There's simply no space between the links :) will submit a new patch Created attachment 49712 [details] [review] Bug 16058: Delete individual news item from koha-news.pl This patch adds a confirm message for deleting a news item from the home page in the staff client. It also gives the ability to delete an individual news item from koha-news.pl with a confirm message. The buttons on koha-news.pl are now styled as font awesome buttons. To test: 1) Go to main intranet page. Click 'Delete' for a news item. 2) Confirm that Cancel stops the Delete, and OK deletes the item and takes you to tools/koha-news.pl 3) Confirm that the buttons (Edit and Delete) on koha-news.pl are now styled as font awesome buttons and the buttons don't wrap on a narrow browser. 4) Confirm that the column heading for the buttons is now "Actions". 5) Confirm that clicking Delete triggers a confirm message. Confirm that Cancel stops the Delete, and OK deletes the item and it no longer shows in the News table or anywhere else. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49725 [details] [review] Bug 16058: Delete individual news item from koha-news.pl This patch adds a confirm message for deleting a news item from the home page in the staff client. It also gives the ability to delete an individual news item from koha-news.pl with a confirm message. The buttons on koha-news.pl are now styled as font awesome buttons. To test: 1) Go to main intranet page. Click 'Delete' for a news item. 2) Confirm that Cancel stops the Delete, and OK deletes the item and takes you to tools/koha-news.pl 3) Confirm that the buttons (Edit and Delete) on koha-news.pl are now styled as font awesome buttons and the buttons don't wrap on a narrow browser. 4) Confirm that the column heading for the buttons is now "Actions". 5) Confirm that clicking Delete triggers a confirm message. Confirm that Cancel stops the Delete, and OK deletes the item and it no longer shows in the News table or anywhere else. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended-patch: just split the td on several lines for readability. Pushed to Master - Should be in the May 2016 release. Thanks! |