Summary: | Remove CSS and images related to old "approve" and "deny" button styles | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, testopia, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 16061, 16064 | ||
Bug Blocks: | |||
Attachments: |
Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles
Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Bug 16062 - (follow-up) Remove CSS and images related to old "approve" and "deny" button styles |
Description
Owen Leonard
2016-03-14 13:51:06 UTC
Created attachment 49098 [details] [review] Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Now that confirmation dialogs have all been udpated to use Font Awesome icons, the old CSS for styling "approve" and "deny" buttons can be removed along with the associated images. To test, apply the patchs for Bugs 16061 and 16064 if necessary. - Search the templates for instances of the "approve" or "deny" class which don't have a Font Awesome icon associated with it. There should be none. - Confirm that there are no other references to the files "approve.gif" and "deny.gif" Created attachment 49128 [details] [review] Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Now that confirmation dialogs have all been udpated to use Font Awesome icons, the old CSS for styling "approve" and "deny" buttons can be removed along with the associated images. To test, apply the patchs for Bugs 16061 and 16064 if necessary. - Search the templates for instances of the "approve" or "deny" class which don't have a Font Awesome icon associated with it. There should be none. - Confirm that there are no other references to the files "approve.gif" and "deny.gif" Signed-off-by: Marc Véron <veron@veron.ch> What about 1126 td input.approve { 1127 background-color : #FFC; 1128 } ? (In reply to Jonathan Druart from comment #3) > What about > 1126 td input.approve { > 1127 background-color : #FFC; > 1128 } > ? I didn't notice that. That was made obsolete by the overhaul of the lists interface. Created attachment 49251 [details] [review] Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Now that confirmation dialogs have all been udpated to use Font Awesome icons, the old CSS for styling "approve" and "deny" buttons can be removed along with the associated images. To test, apply the patchs for Bugs 16061 and 16064 if necessary. - Search the templates for instances of the "approve" or "deny" class which don't have a Font Awesome icon associated with it. There should be none. - Confirm that there are no other references to the files "approve.gif" and "deny.gif" Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 49252 [details] [review] Bug 16062 - (follow-up) Remove CSS and images related to old "approve" and "deny" button styles Remove another obsolete CSS rule for input.approve Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - should be in the May 2016 release. Thanks! |