Bug 16064

Summary: Remove use of image to indicate approval in tags moderation
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, veron
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/tags/review.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 16062    
Attachments: Bug 16064 - Remove use of image to indicate approval in tags moderation
Bug 16064 - Remove use of image to indicate approval in tags moderation
Bug 16064 - Remove use of image to indicate approval in tags moderation

Description Owen Leonard 2016-03-14 14:17:20 UTC
I would like to be able to eliminate use of "approve.gif" as part of Bug 16062, so I propose to take it out of the tags moderation template and use text instead. This has the added benefit of being more consistent and accessible.
Comment 1 Owen Leonard 2016-03-14 14:22:52 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-14 16:59:39 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-16 11:35:17 UTC
Created attachment 49215 [details] [review]
Bug 16064 - Remove use of image to indicate approval in tags moderation

This patch updates the tags moderation template to use text labels to
mark tag moderation status, eliminating the use of an image file to
signify approval.

To test you should have some tags in each approval state: pending,
approved, and rejected.

- Apply the patch and go to Tools -> Tags.
- Confirm that the status of each tag is clearly shown with a text
  label.

Works as expected (Do not forget to set filter at the left to 'all' for testing)
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-21 21:30:39 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!