Summary: | JavaScript error on new patron form when duplicate is suspected | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, gmcharlt, jonathan.druart, julian.maurice, kyle.m.hall, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/members/memberentry.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 15206, 16065 | ||
Bug Blocks: | |||
Attachments: |
Bug 16066 - JavaScript error on new patron form when duplicate is suspected
Bug 16066 - JavaScript error on new patron form when duplicate is suspected Bug 16066 - JavaScript error on new patron form when duplicate is suspected |
Description
Owen Leonard
2016-03-14 15:22:44 UTC
Created attachment 49111 [details] [review] Bug 16066 - JavaScript error on new patron form when duplicate is suspected When a new patron is submitted which is suspected to be a duplicate, the entry form is redisplayed with a new name attribute, "form_nodouble." Other scripts on the page still look for a form named "form," so there is an error. This patch removes the use of "form_nodouble" on the assumption that it is unnecessary to name the form something different when a duplicate is suspected. All the same validation scripts should be run on the form either way. To test, apply the patch and clear your cache if necessary. - Go to Patrons -> New patron and add a patron which matches an existing one in order to trigger the duplicate warning. - Confirm that Firebug (or similar) is not reporting a JavaScript error. - Confirm that the 'Edit existing' and 'Save as new' buttons work correctly. Created attachment 49113 [details] [review] Bug 16066 - JavaScript error on new patron form when duplicate is suspected When a new patron is submitted which is suspected to be a duplicate, the entry form is redisplayed with a new name attribute, "form_nodouble." Other scripts on the page still look for a form named "form," so there is an error. This patch removes the use of "form_nodouble" on the assumption that it is unnecessary to name the form something different when a duplicate is suspected. All the same validation scripts should be run on the form either way. To test, apply the patch and clear your cache if necessary. - Go to Patrons -> New patron and add a patron which matches an existing one in order to trigger the duplicate warning. - Confirm that Firebug (or similar) is not reporting a JavaScript error. - Confirm that the 'Edit existing' and 'Save as new' buttons work correctly. Reproduced JavaScript error and verified that it no longer appears with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49175 [details] [review] Bug 16066 - JavaScript error on new patron form when duplicate is suspected When a new patron is submitted which is suspected to be a duplicate, the entry form is redisplayed with a new name attribute, "form_nodouble." Other scripts on the page still look for a form named "form," so there is an error. This patch removes the use of "form_nodouble" on the assumption that it is unnecessary to name the form something different when a duplicate is suspected. All the same validation scripts should be run on the form either way. To test, apply the patch and clear your cache if necessary. - Go to Patrons -> New patron and add a patron which matches an existing one in order to trigger the duplicate warning. - Confirm that Firebug (or similar) is not reporting a JavaScript error. - Confirm that the 'Edit existing' and 'Save as new' buttons work correctly. Reproduced JavaScript error and verified that it no longer appears with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Does not concern stable versions, status changed to RESOLVED |