Summary: | Koha::Cache, fastmmap caching system is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jacek Ablewicz <abl> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, dcook, fridolin.somers, jonathan.druart, m.de.rooy, martin.renvoize, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.01, 20.05.07
|
Circulation function: | |
Bug Depends on: | 11998 | ||
Bug Blocks: | |||
Attachments: |
Bug 16067: Remove FastMmap
Bug 16067: Remove FastMmap Bug 16067: Remove FastMmap |
Description
Jacek Ablewicz
2016-03-14 16:32:24 UTC
Personally, I opt for leaving it as is (i.e. broken) for the time being. At least that way we will gather some info regarding prevalence of this caching system in real-world koha installations ;) I've been asking myself the question of 'whose using all these different caching systems?' for a while now. We seem to needlessly complicate our caching by supporting so many options (and we even removed the use of CHI to do it!) +1 for leave it broken, then maybe we'll actually find someone who might be using it ;) (In reply to Jacek Ablewicz from comment #2) > Personally, I opt for leaving it as is (i.e. broken) for the time being. At > least that way we will gather some info regarding prevalence of this caching > system in real-world koha installations ;) It's a bit rude but I totally support this idea. Cant we get information about that via HEA? Although HEA is not complete of course, but to be rude too if you do not join HEA, do not complain that we did not know that you were still using it.. (In reply to Marcel de Rooy from comment #5) > Cant we get information about that via HEA? Although HEA is not complete of > course, but to be rude too if you do not join HEA, do not complain that we > did not know that you were still using it.. Hea can only show what we built into it to show... we'd need to add information about caching and then wait for people to actually update. If it's broken, why not deprecate it with a note in the release notes? Are good reasons someone would not just switch to a better (memcached?) one? With bug 21955 removing Cache::Memory maybe it's time to remove FastMmap as well? I think we can fairly safely remove this option too.. if it's been broken for 2 years already it's not really all that likely it's being used in production surely! Created attachment 83304 [details] [review] Bug 16067: Remove FastMmap Created attachment 113990 [details] [review] Bug 16067: Remove FastMmap It is known to be broken, we should remove its implementation Created attachment 114003 [details] [review] Bug 16067: Remove FastMmap It is known to be broken, we should remove its implementation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Fast QAing this one, it's simple tidy up, works as expected, passes QA scripts and tests all pass.. Passing QA Pushed to master for 20.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 RIP ;) Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |