| Summary: | Use Font Awesome icons in authority record duplicate warning dialog | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/cataloguing/authorities.pl | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 16080 | ||
| Attachments: |
Bug 16071 - Use Font Awesome icons in authority duplicate warning dialog
[SIGNED-OFF]Bug 16071: Use Font Awesome icons in authority duplicate warning dialog Bug 16071: Use Font Awesome icons in authority duplicate warning dialog |
||
|
Description
Owen Leonard
2016-03-14 17:33:03 UTC
Created attachment 49133 [details] [review] Bug 16071 - Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using <h3> instead of <h4> in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. Created attachment 49230 [details] [review] [SIGNED-OFF]Bug 16071: Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using <h3> instead of <h4> in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Created attachment 49246 [details] [review] Bug 16071: Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using <h3> instead of <h4> in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - should be in the May 2016 release. Thanks! |