Bug 16073

Summary: Circulation is completely broken
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: abl, brendan, gmcharlt, julian.maurice, kyle.m.hall, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15656    
Bug Blocks: 16082    
Attachments: Bug 16073: Fix software error in circulation.pl
Bug 16073: Fix software error in circulation.pl
Bug 16073: (follow-up) Fix software error in circulation.pl
Bug 16073: Fix software error in circulation.pl
Bug 16073: (follow-up) Fix software error in circulation.pl

Description Jonathan Druart 2016-03-14 18:40:28 UTC
To reproduce, just go to circ/circulation.pl:

Can't call method "guarantor" on an undefined value at /home/koha/src/circ/circulation.pl line 588.
 at /home/koha/src/circ/circulation.pl line 673

Introduced by bug 15656
Comment 1 Jonathan Druart 2016-03-14 18:43:00 UTC Comment hidden (obsolete)
Comment 2 Jacek Ablewicz 2016-03-15 10:00:35 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-16 09:34:58 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi 2016-03-17 15:14:13 UTC
Created attachment 49273 [details] [review]
Bug 16073: Fix software error in circulation.pl

Can't call method "guarantor" on an undefined value at
/home/koha/src/circ/circulation.pl line 588.
 at /home/koha/src/circ/circulation.pl line 673

Introduced by bug 15656

Test plan:
Just trigger circ/circulation.pl

Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Triggered circ/circulation.pl - nothing exploded, and error is gone
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Comment 5 Tomás Cohen Arazi 2016-03-17 15:14:22 UTC
Created attachment 49274 [details] [review]
Bug 16073: (follow-up) Fix software error in circulation.pl

Do not crash if the patron does not exist.

Test plan:
Access circ/circulation.pl?borrowernumber=42424242
you should get an error without this patch
With this patch, you will get an empty patron detail page (should be
fixed in another patch, but this behavior exists for a while)

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Comment 6 Tomás Cohen Arazi 2016-03-17 15:15:25 UTC
Simple patches that fix the issue. They pass the QA scripts and have
really bad commit messages :-P
Comment 7 Brendan Gallagher 2016-03-21 16:07:45 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 8 Julian Maurice 2016-03-23 06:28:54 UTC
Does not concern stable versions, status changed to RESOLVED