| Summary: | Accept CLI params for the Makefile.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alex Sassmannshausen <alex> |
| Component: | Installation and upgrade (command-line installer) | Assignee: | Alex Sassmannshausen <alex> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, mirko, mtompset |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Patch implementing features raised here.
Bug 16083 Allow cli overrides for makefile settings. Bug 16083 Allow cli overrides for makefile settings. Bug 16083: [QA FOLLOWUP] Add more cli arguments. |
||
|
Description
Alex Sassmannshausen
2016-03-16 16:59:46 UTC
Created attachment 49235 [details] [review] Patch implementing features raised here. Test Plan: - Run the Makefile without parameters — the script should work as before. - Run the script with the '-h' flag — it should output help. - Run the script with any number of additional legal flags — the script should skip those questions in its interactive mode. What about the SRU Biblio and Authority port numbers? Created attachment 56396 [details] [review] Bug 16083 Allow cli overrides for makefile settings. Currently the Makefile.pl script only accepts the '--prev-install-log' commandline flag for reading Koha configuration values from the previous installation. The Makefile does not have help output. The aim of this bug report is to add 2 things: - --help output - commandline parameters that should allow automating many of the common settings if desired - when commandline parameters are not passed we simply fall back to the interactive method of old Test Plan: - Run the Makefile without parameters — the script should work as before. - Run the script with the '-h' flag — it should output help. - Run the script with any number of additional legal flags — the script should skip those questions in its interactive mode. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Reworked the log message with Bugzilla comments. Created attachment 58555 [details] [review] Bug 16083 Allow cli overrides for makefile settings. Currently the Makefile.pl script only accepts the '--prev-install-log' commandline flag for reading Koha configuration values from the previous installation. The Makefile does not have help output. The aim of this bug report is to add 2 things: - --help output - commandline parameters that should allow automating many of the common settings if desired - when commandline parameters are not passed we simply fall back to the interactive method of old Test Plan: - Run the Makefile without parameters — the script should work as before. - Run the script with the '-h' flag — it should output help. - Run the script with any number of additional legal flags — the script should skip those questions in its interactive mode. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Reworked the log message with Bugzilla comments. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: perltidy GetOptions block (In reply to M. Tompsett from comment #2) > What about the SRU Biblio and Authority port numbers? This question was never dealt with. Created attachment 58612 [details] [review] Bug 16083: [QA FOLLOWUP] Add more cli arguments. * Makefile.PL: Add `zebra_sru_host`, `zebra_sru_biblios_port` & `zebra_sru_authorities_port` as possible command line arguments. (In reply to M. Tompsett from comment #5) > (In reply to M. Tompsett from comment #2) > > What about the SRU Biblio and Authority port numbers? > > This question was never dealt with. My latest patch adds SRU Biblio and Authority port numbers as well as SRU Host commandline arguments. Alex (In reply to Alex Sassmannshausen from comment #7) > My latest patch adds SRU Biblio and Authority port numbers as well as SRU > Host commandline arguments. Thanks that looks great. I'm happy to leave this at Passed QA now. :) Pushed to master for 17.05, thanks Alex! This won't get ported back to 16.11.x as it is an enhancement. |