Summary: | Acquisitions -> Invoice broken by Bug 15084 | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Acquisitions | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, julian.maurice, veron |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/acqui/invoice.pl?invoiceid=X | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 15084 | ||
Bug Blocks: | |||
Attachments: |
Bug 16089: Acquisitions -> Invoice broken by Bug 15084
[SIGNED-OFF] Bug 16089: Acquisitions -> Invoice broken by Bug 15084 Bug 16089: (Follow up) Display currency symbol properly Bug 16089: Acquisitions -> Invoice broken by Bug 15084 Bug 16089: (Follow up) Display currency symbol properly |
Description
Owen Leonard
2016-03-17 13:45:01 UTC
Confirmed. Log says: [Thu Mar 17 15:25:50 2016] invoice.pl: Use of uninitialized value in addition (+) at /usr/share/kohaclone/acqui/invoice.pl line 164., referer: http://192.168.1.24:8080/cgi-bin/koha/acqui/invoices.pl?op=do_search [Thu Mar 17 15:25:50 2016] invoice.pl: Use of uninitialized value in addition (+) at /usr/share/kohaclone/acqui/invoice.pl line 164., referer: http://192.168.1.24:8080/cgi-bin/koha/acqui/invoices.pl?op=do_search [Thu Mar 17 15:25:50 2016] invoice.pl: Can't use string ("Koha::Acquisition::Currency") as a HASH ref while "strict refs" in use at /usr/share/kohaclone/Koha/Object.pm line 248., referer: http://192.168.1.24:8080/cgi-bin/koha/acqui/invoices.pl?op=do_search Seems to be related to invoice.pl line 181: currency => Koha::Acquisition::Currency->get_active->currency, If I comment out this line, the error disappears. However, curency is used 3 times in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt Created attachment 49272 [details] [review] Bug 16089: Acquisitions -> Invoice broken by Bug 15084 To test: - Reproduce error described in first comment. - Apply patch - Try to reproduce error. Page will display as expected. Created attachment 49275 [details] [review] [SIGNED-OFF] Bug 16089: Acquisitions -> Invoice broken by Bug 15084 To test: - Reproduce error described in first comment. - Apply patch - Try to reproduce error. Page will display as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Another issue I just noticed, and I assume it is at least related. In the table of invoice details where it used to show the currency code Total tax exc. (USD) it now reads Total tax exc. (Koha::Acquisition::Currency=HASH(0x7587d38)) A separate issue, or the fix is incomplete? Created attachment 49278 [details] [review] Bug 16089: (Follow up) Display currency symbol properly This patch fixes the display of the currency symbol on invoice.tt See comment #5 Created attachment 49305 [details] [review] Bug 16089: Acquisitions -> Invoice broken by Bug 15084 To test: - Reproduce error described in first comment. - Apply patch - Try to reproduce error. Page will display as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 49306 [details] [review] Bug 16089: (Follow up) Display currency symbol properly This patch fixes the display of the currency symbol on invoice.tt See comment #5 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks Marc for the patch, and Owen for the catch! :) git grep 'Currency->get_active' does not return any results with this patch applied. Pushed to Master - Should be in the May 2016 Release. Thanks! Does not concern stable versions, status changed to RESOLVED |