Bug 16101

Summary: Exclude /usr/share/perl errors in check_valid
Product: Project Infrastructure Reporter: Mark Tompsett <mtompset>
Component: QA toolsAssignee: Mark Tompsett <mtompset>
Status: RESOLVED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 16101: Exclude /usr/share/perl errors in check_valid

Description Mark Tompsett 2016-03-18 02:07:55 UTC
Bug 15870 triggers a FAILURE on the koha qa test tools.

This is caused by /usr/share/perl/5.20/fields.pm line 135, which is visible when you run perl -cw {filename} explicitly.

As it makes no sense for Koha QA Test tools to care about the quality of /usr/share/perl type libraries when validating Koha code, exclude /usr/share/perl triggered issues.
Comment 1 Mark Tompsett 2016-03-18 02:09:46 UTC
Created attachment 49296 [details] [review]
Bug 16101: Exclude /usr/share/perl errors in check_valid

TEST PLAN
---------
1) In kohaclone, apply bug 15870
2) Run the koha qa test tools
   -- the valid check fails
3) In your qa test tools apply this patch
4) In kohaclone, run the koha qa test tools again
   -- everything should pass
Comment 2 Mark Tompsett 2016-03-18 18:55:11 UTC
16104 addresses the Koha issue rather than tweak the tool to exclude particular messages, which is a better solution to the same problem.

*** This bug has been marked as a duplicate of bug 16104 ***