Summary: | Remove FK constraint for sms_provider_id in deletedborrowers | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16103: Remove FK sms_provider_id in deletedborrowers
Bug 16103: Remove FK sms_provider_id in deletedborrowers |
Description
Marcel de Rooy
2016-03-18 13:11:37 UTC
Created attachment 49312 [details] [review] Bug 16103: Remove FK sms_provider_id in deletedborrowers This patch removes the FK constraint for sms_provider_id in table deletedborrowers. (We do not need FKs in that table.) It just corrects a newly added db revision in updatedatabase. If this is pushed before releasing master, no need to do anything more. Note that this key was not found in kohastructure and the DBIx schema. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Fixed in Master! (just pushed update) Created attachment 49742 [details] [review] Bug 16103: Remove FK sms_provider_id in deletedborrowers This patch removes the FK constraint for sms_provider_id in table deletedborrowers. (We do not need FKs in that table.) It just corrects a newly added db revision in updatedatabase. If this is pushed before releasing master, no need to do anything more. Note that this key was not found in kohastructure and the DBIx schema. Edit: To test: - With master DB run $ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests pass - Create a clean 3.22.00 DB - Run the upgrade process $ perl installer/data/mysql/updatedatabase.pl - Run $ prove t/db_dependent/TestBuilder.t => FAIL: Tests fail due to discrepancies in DB structure - Re-create teh clean 3.22.00 DB - Apply the patch - Run the upgrade process $ perl installer/data/mysql/updatedatabase.pl - Run $ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests now pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |