|
Description
Marjorie Barry-Vila
2016-03-21 15:35:56 UTC
+1 Created attachment 107786 [details] [review] Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Created attachment 107835 [details] [review] Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> I was able to follow the test plan and select a renewal date for batch renew. Created attachment 107865 [details] [review] Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Sorry Henry, I had to redo the patch. I embedded a patch of this development on bug 16748 (as you noticed). As I modified the patch I need to ask for another signoff. Please retest it if you have some time. Created attachment 107890 [details] [review] Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 107891 [details] [review] Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Created attachment 108639 [details] [review] Bug 24288: Add wording to authorized value interface to indicate valid code length Chnged NOTFORLOAN to NOT_LOAN This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. Created attachment 108640 [details] [review] Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 108641 [details] [review] Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 108658 [details] [review] Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> Created attachment 108659 [details] [review] Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> Created attachment 108661 [details] [review] Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 108662 [details] [review] Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 108663 [details] [review] Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 108665 [details] [review] Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> I think this is close, but not quite right: Instead of modeling the 'specify due date' feature, this should model the "renewal due date" feature we have in circulation (footer of the circulation table). So we should change the labelling and also the 'activation' conditions. The renewal due date option is always visible and doesn't depend on the SpecifyDueDate preference. What do you think? Created attachment 108776 [details] [review] Bug 16112: Do not depend on SpecifyDueDate It's possible to specify a renewal due date in the checkouts table even if SpecifyDueDate is off. Also change the label from "Specify due date:" to "Renewal due date:" Created attachment 108871 [details] [review] Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 108872 [details] [review] Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 108873 [details] [review] Bug 16112: Do not depend on SpecifyDueDate It's possible to specify a renewal due date in the checkouts table even if SpecifyDueDate is off. Also change the label from "Specify due date:" to "Renewal due date:" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |